ETLCPP has 2 versions on platformio registry: arduino one (which is up-to-date), and non-arduino one. The latter is 19.3.5 and has not been updated for a while. Is it possible to update it? I'm using it for CubeMX project, and seemingly I don't want an arduino version of the library (though I don't exactly know what the differences are).

I think the etl would greatly benefit of an owning version of the delegate class similar to std::function but instead it stores the closure in an internal buffer (being it is on the stack with a user-defined static capacity) instead of heap allocated memory. The internal buffer size could be spezified by a template parameter.

Some implementations I found are:

• https://github.com/rigtorp/Function
• https://github.com/tacticalmelonfarmer/callable

Hello !

I am trying to use this library on PlatformIO IDE, but I'm having no luck. I'm using it with lib_deps = 930 inside platformio.ini.

I've read here: https://www.etlcpp.com/setup.html and I made etl_profile.h and I put it inside include folder in the project's folder:

#ifndef __ETL_PROFILE_H__
#define __ETL_PROFILE_H__

#define ETL_THROW_EXCEPTIONS
#define ETL_VERBOSE_ERRORS
#define ETL_CHECK_PUSH_POP

#endif

With:

#include <etl_profile.h>
#include <deque.h>

compiling gives me the following error:

compilation terminated.
*** [.pioenvs/esp32doit-devkit-v1/lib14e/Embedded Template Library_ID930/crc16.cpp.o] Error 1
compilation terminated.
*** [.pioenvs/esp32doit-devkit-v1/lib14e/Embedded Template Library_ID930/binary.cpp.o] Error 1
In file included from .piolibdeps/Embedded Template Library_ID930/src/c/ecl_timer.c:32:0:
.piolibdeps/Embedded Template Library_ID930/src/c/ecl_timer.h:34:22: fatal error: ecl_user.h: No such file or directory

Without #include <etl_profile.h> it says:

compilation terminated.
*** [.pioenvs/esp32doit-devkit-v1/lib14e/Embedded Template Library_ID930/binary.cpp.o] Error 1
In file included from .piolibdeps/Embedded Template Library_ID930/src/crc16.cpp:33:0:
.piolibdeps/Embedded Template Library_ID930/src/platform.h:49:25: fatal error: etl_profile.h: No such file or directory

Hi everyone,

I've been trying to compile a very simple application for a TI TMS570 using TI Code Composer Studio (version 9.0.1).

As mentioned in the ETL documentation, I defined the macro __STDC_LIMIT_MACROS in the project properties (I wasn't sure about which value to set though).

My application uses a very simple class called from the sys_main.c.

#include "etl/vector.h"

class MyClass {
public:
    typedef etl::vector<etl::vector<uint8_t, 14>, 32> Container;

    typedef struct{
        etl::vector<uint16_t, 14> subVector;
    }Cell_Voltage_t;


    MyClass(size_t newSize);
    etl::ivector<Cell_Voltage_t>& GetFullVector(void);

    virtual ~MyClass();

private:
    etl::vector<Cell_Voltage_t, 32> mVector;

};

However, since the main function is in a C file I had to implement a simple wrapper :

#include "MyClass.h"

typedef void* MyClass_t;

extern "C" {
	MyClass_t CreateMyClassInstance(size_t newSize){
            return new MyClass(newSize);
        }
	
	etl::ivector<Cell_Voltage_t>& GetFullVector(MyClass_t pMyClass){
	    MyClass* pClass = static_cast<MyClass*>(pMyClass);
	    return pClass->GetFullVector();
        }
}

And finally, sys_main.c

#include "MyClassWrapper.h"

int main(void)
{
    /* USER CODE BEGIN (3) */
    /****************************************************************************
    * System Initialization
    *****************************************************************************/
    SysTick_Init();
    Wdt_Init();

    size_t new_size = 1;
    MyClass_t myClassInstance = CreateMyClassInstance(new_size);

    while(1){
    }

    return 0;
}

This application does not compile using TI Code Composer Studio v9.0.1 with compiler version 18.12.2 LTS. It does however compile using GCC and using Atollic TrueStudio.

• Step 1 : Vector.h can't find <new> + some errors about methods being ambiguous. vector.h, line 41: fatal error #1965: cannot open source file "new" and etl\stl\alternate\utility.h", line 98: error #268: "std::pair" is ambiguous

compilation_output_step1.txt

After searching a little bit, I changed #include <new> to #include_next <new.stdh> to match the TI CCS directory structure. This solves the first compilation error but generates a lot more in different parts of the ETL code.

• Step 2: Bunch of errors in TI's new implementation and in ETL.

compilation_output_step2.txt

I'm pretty sure that this is due to a misconfiguration, but apart from the C (set to C99 by default) or C++ version (set to C++14 by CCS, and cannot be changed...) which can't be modified and the macro mentioned in the documentation, I can't find anything!

Anyone having a similar experience on this aspect?

Thanks!

When installing Embedded Template Library v19.3.4 from the Library Manager in Arduino IDE 1.8.13, I get many instances of the following messages in the console.

Invalid library found in C:\Users\me\Documents\Arduino\libraries\Embedded_Template_Library: no headers files (.h) found in C:\Users\me\Documents\Arduino\libraries\Embedded_Template_Library

I think the relevant info to resolve the issue would probably be found here: https://arduino.github.io/arduino-cli/latest/library-specification/

I am using some nice non volatile FRAM chips (my specific modules are https://www.adafruit.com/product/4719 from Adafruit, but I guess the exact model makes no difference). These are nice, big banks of "external" non volatile memory.

I would like to have some ETL containers living fully (i.e., both the data buffer, and the "container magics" around them) on such an external memory bank. These have a very simple API, something like:

fram.write8(address, byte_value);
fram.read8(address);

This allows to write and read individual bytes of data at individual addresses easily.

Any way / how to make an ETL container live on such an external memory bank with an API to access it? I looked at the documentation but did not find hints of how I could do something like this.

When I compile the unit tests with GCC, all test files compile successfully. When I compile with Clang (currently using OS X Clang), the following files fail to compile with a consistent error pattern:

'test/test_deque.cpp',
'test/test_flat_map.cpp',
'test/test_flat_multimap.cpp',
'test/test_flat_multiset.cpp',
'test/test_flat_set.cpp',
'test/test_map.cpp',
'test/test_multimap.cpp',
'test/test_multiset.cpp',
'test/test_reference_flat_map.cpp',
'test/test_reference_flat_multimap.cpp',
'test/test_reference_flat_multiset.cpp',
'test/test_reference_flat_set.cpp',
'test/test_pearson.cpp',
'test/test_set.cpp',
'test/test_string_view.cpp',
'test/test_to_u16string.cpp',
'test/test_to_u32string.cpp',
'test/test_to_string.cpp',
'test/test_to_wstring.cpp',
'test/test_unordered_map.cpp',
'test/test_unordered_multimap.cpp',
'test/test_unordered_multiset.cpp',
'test/test_unordered_set.cpp',

This is the primary error pattern:

In file included from ../test/test_flat_multimap.cpp:29:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/UnitTest++.h:1:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/UnitTestPP.h:6:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:6:
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/Checks.h:24:32: error: invalid operands to binary expression ('basic_ostream<char, std::__1::char_traits<char> >' and 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator')
         stream << "Expected " << expected << " but was " << actual;
         ~~~~~~~~~~~~~~~~~~~~~ ^  ~~~~~~~~
../test/test_flat_multimap.cpp:437:7: note: in instantiation of function template specialization 'UnitTest::CheckEqual<etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator, etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator>' requested here
      CHECK_EQUAL(constData.begin(), std::begin(constData));
      ^
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:151:27: note: expanded from macro 'CHECK_EQUAL'
      #define CHECK_EQUAL UNITTEST_CHECK_EQUAL
                          ^
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:40:17: note: expanded from macro 'UNITTEST_CHECK_EQUAL'
      UnitTest::CheckEqual(*UnitTest::CurrentTest::Results(), expected, actual, UnitTest::TestDetails(*UnitTest::CurrentTest::Details(), __LINE__)); \
                ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:218:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const void *' for 1st argument; take the address of the argument with &
    basic_ostream& operator<<(const void* __p);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/type_traits:4830:3: note: candidate function template not viable: no known conversion from 'basic_ostream<char, std::__1::char_traits<char> >' to 'std::byte' for 1st argument
  operator<< (byte  __lhs, _Integer __shift) noexcept
  ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:194:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'std::__1::basic_ostream<char> &(*)(std::__1::basic_ostream<char> &)' for 1st argument
    basic_ostream& operator<<(basic_ostream& (*__pf)(basic_ostream&))
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:198:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'basic_ios<std::__1::basic_ostream<char, std::__1::char_traits<char> >::char_type, std::__1::basic_ostream<char, std::__1::char_traits<char> >::traits_type> &(*)(basic_ios<std::__1::basic_ostream<char, std::__1::char_traits<char> >::char_type, std::__1::basic_ostream<char, std::__1::char_traits<char> >::traits_type> &)' (aka 'basic_ios<char, std::__1::char_traits<char> > &(*)(basic_ios<char, std::__1::char_traits<char> > &)') for 1st argument
    basic_ostream& operator<<(basic_ios<char_type, traits_type>&
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:203:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'std::__1::ios_base &(*)(std::__1::ios_base &)' for 1st argument
    basic_ostream& operator<<(ios_base& (*__pf)(ios_base&))
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:206:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'bool' for 1st argument
    basic_ostream& operator<<(bool __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:207:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'short' for 1st argument
    basic_ostream& operator<<(short __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:208:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'unsigned short' for 1st argument
    basic_ostream& operator<<(unsigned short __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:209:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'int' for 1st argument
    basic_ostream& operator<<(int __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:210:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'unsigned int' for 1st argument
    basic_ostream& operator<<(unsigned int __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:211:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'long' for 1st argument
    basic_ostream& operator<<(long __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:212:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'unsigned long' for 1st argument
    basic_ostream& operator<<(unsigned long __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:213:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'long long' for 1st argument
    basic_ostream& operator<<(long long __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:214:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'unsigned long long' for 1st argument
    basic_ostream& operator<<(unsigned long long __n);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:215:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'float' for 1st argument
    basic_ostream& operator<<(float __f);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:216:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'double' for 1st argument
    basic_ostream& operator<<(double __f);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:217:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'long double' for 1st argument
    basic_ostream& operator<<(long double __f);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:219:20: note: candidate function not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'basic_streambuf<std::__1::basic_ostream<char, std::__1::char_traits<char> >::char_type, std::__1::basic_ostream<char, std::__1::char_traits<char> >::traits_type> *' (aka 'basic_streambuf<char, std::__1::char_traits<char> > *') for 1st argument
    basic_ostream& operator<<(basic_streambuf<char_type, traits_type>* __sb);
                   ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:755:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'char' for 2nd argument
operator<<(basic_ostream<_CharT, _Traits>& __os, char __cn)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:788:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'char' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, char __c)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:795:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'signed char' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, signed char __c)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:802:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'unsigned char' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, unsigned char __c)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:816:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const char *' for 2nd argument
operator<<(basic_ostream<_CharT, _Traits>& __os, const char* __strn)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:862:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const char *' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, const char* __str)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:869:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const signed char *' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, const signed char* __str)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:877:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const unsigned char *' for 2nd argument
operator<<(basic_ostream<char, _Traits>& __os, const unsigned char* __str)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1061:1: note: candidate function template not viable: no known conversion from 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator' to 'const std::__1::error_code' for 2nd argument
operator<<(basic_ostream<_CharT, _Traits>& __os, const error_code& __ec)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:748:1: note: candidate template ignored: deduced conflicting types for parameter '_CharT' ('char' vs. 'etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator')
operator<<(basic_ostream<_CharT, _Traits>& __os, _CharT __c)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:809:1: note: candidate template ignored: could not match 'const _CharT *' against 'etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os, const _CharT* __str)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1044:1: note: candidate template ignored: could not match 'basic_string<type-parameter-0-0, type-parameter-0-1, type-parameter-0-2>' against 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os,
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1069:1: note: candidate template ignored: could not match 'shared_ptr<type-parameter-0-2>' against 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os, shared_ptr<_Yp> const& __p)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1088:1: note: candidate template ignored: could not match 'bitset<_Size>' against 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os, const bitset<_Size>& __x)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1034:1: note: candidate template ignored: requirement '!is_lvalue_reference<basic_ostream<char> &>::value' was not satisfied [with _Stream = std::__1::basic_ostream<char> &, _Tp = etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator]
operator<<(_Stream&& __os, const _Tp& __x)
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1052:1: note: candidate template ignored: could not match 'basic_string_view<type-parameter-0-0, type-parameter-0-1>' against 'etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os,
^
/Library/Developer/CommandLineTools/usr/include/c++/v1/ostream:1081:1: note: candidate template ignored: could not match 'unique_ptr<type-parameter-0-2, type-parameter-0-3>' against 'const etl::ireference_flat_multimap<int, TestDataNDC<std::__1::basic_string<char> >, etl::less<int> >::const_iterator'
operator<<(basic_ostream<_CharT, _Traits>& __os, unique_ptr<_Yp, _Dp> const& __p)
^
4 warnings and 2 errors generated.
[104/125] Compiling C++ object 'etl_un..._vector_pointer_external_buffer.cpp.o'

A secondary pattern that occurs is:

In file included from ../test/test_string_view.cpp:29:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/UnitTest++.h:1:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/UnitTestPP.h:6:
In file included from /usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:6:
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/Checks.h:24:32: error: call to function 'operator<<' that is neither visible in the template definition nor found by argument-dependent lookup
         stream << "Expected " << expected << " but was " << actual;
                               ^
../test/test_string_view.cpp:386:7: note: in instantiation of function template specialization 'UnitTest::CheckEqual<etl::basic_string_view<char, etl::char_traits<char> >, etl::basic_string_view<char, etl::char_traits<char> > >' requested here
      CHECK_EQUAL(view1, sub);
      ^
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:151:27: note: expanded from macro 'CHECK_EQUAL'
      #define CHECK_EQUAL UNITTEST_CHECK_EQUAL
                          ^
/usr/local/Cellar/unittest-cpp/2.0.0/include/UnitTest++/CheckMacros.h:40:17: note: expanded from macro 'UNITTEST_CHECK_EQUAL'
      UnitTest::CheckEqual(*UnitTest::CurrentTest::Results(), expected, actual, UnitTest::TestDetails(*UnitTest::CurrentTest::Details(), __LINE__)); \
                ^
../test/test_string_view.cpp:57:17: note: 'operator<<' should be declared prior to the call site or in namespace 'etl'
  std::ostream& operator << (std::ostream& os, const View& view)
                ^
1 error generated.

Compiler : GNU ARM GCC 9-2019-q4-major CPP version : c++14

Hello, My project was working fine with the ETL (15.4.2), i would like to megrate the ETL to it latest version (18.14.1). But when i replace the include folder in my project, it doesn't compile anymore !! A lot of errors like :

ell/algorithm.h:2159:3: error: ‘ETL_NODISCARD’ does not name a type
error: ‘pair’ in namespace ‘std’ does not name a template type
etl/utility.h:116:5: error: ‘ETL_CONSTEXPR’ does not name a type
  116 |     ETL_CONSTEXPR pair()
etl/utility.h:123:5: error: ‘ETL_CONSTEXPR14’ does not name a type
etl/iterator.h:70:13: error: ‘ETL_OR_STD’ does not name a type
etl/iterator.h:273:5: error: ‘ETL_CONSTEXPR17’ does not name a type
  273 |     ETL_CONSTEXPR17 reverse_iterator(const reverse_iterator<TOther>& other)
etl/integral_limits.h:136:35: error: ‘CHAR_BIT’ was not declared in this scope
etl/memory.h:418:27: error: ‘distance’ is not a member of ‘etl’; did you mean ‘std::distance’?
  418 |     count += int32_t(etl::distance(i_begin, i_end));
etl/private/pvoidvector.h:625:47: error: 'equal' is not a member of 'etl'; did you mean 'equal_to'?
  625 |     return (lhs.size() == rhs.size()) && etl::equal(lhs.begin(), lhs.end(), rhs.begin());

The only definition i used in the Makefile is CXXFLAGS += -DPROFILE_ARM_V7_GENERIC

My question: What are the steps to migrate my project as there have been a lot of changes since 15.4.2 ? Thank you

What happened

Hi, you've created a great library! But i discovered that source code of tests and maybe source code of library itself contains multiple instances of at least two kinds of problems:

1. undefined behavior
2. memory issues.

How to reproduce

It can be easily reproduced by addition of "-fsanitize=address,undefined" to CMAKE_CXX_FLAGS on every supported compiler. As for example:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=address,undefined")

Or for single type of check:

set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined")

You can checkout concrete example for gcc/clang from this commit

You can see failing results in github actions ci.

Reports example

• Undefined behavior example

/home/runner/work/etl/etl/test/test_array_wrapper.cpp:264:7: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:278:7: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:279:7: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:282:7: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:283:7: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:332:37: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/test_array_wrapper.cpp:353:37: runtime error: index -1 out of bounds for type 'int [5]'
/home/runner/work/etl/etl/test/../include/etl/bit.h:163:19: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int'
/home/runner/work/etl/etl/test/test_bit.cpp:184:19: runtime error: shift exponent 32 is too large for 32-bit type 'unsigned int'
/home/runner/work/etl/etl/test/../include/etl/bit.h:163:19: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'
/home/runner/work/etl/etl/test/test_bit.cpp:184:19: runtime error: shift exponent 64 is too large for 64-bit type 'long unsigned int'
/home/runner/work/etl/etl/test/../include/etl/bitset.h:454:28: runtime error: left shift of negative value -128
/home/runner/work/etl/etl/test/../include/etl/bit_stream.h:237:44: runtime error: left shift of negative value -91
/home/runner/work/etl/etl/test/../include/etl/bit_stream.h:237:44: runtime error: left shift of negative value -37

• Address issue example

==4661==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffe36665b90 at pc 0x55db03f737cc bp 0x7ffe366655e0 sp 0x7ffe366655d0
READ of size 8 at 0x7ffe36665b90 thread T0
    #0 0x55db03f737cb in (anonymous namespace)::Suitetest_callback_timer_interrupt::Testcallback_timer_interrupt_log_timer_calls::RunImpl() const::{lambda()#1}::operator()() const (/home/runner/work/etl/etl/test/etl_tests+0xadce7cb)
    #1 0x55db03f7b96f in void etl::delegate<void ()>::lambda_stub<(anonymous namespace)::Suitetest_callback_timer_interrupt::Testcallback_timer_interrupt_log_timer_calls::RunImpl() const::{lambda()#1}>(void*) (/home/runner/work/etl/etl/test/etl_tests+0xadd696f)
    #2 0x55db03ef9d84 in etl::delegate<void ()>::operator()() const (/home/runner/work/etl/etl/test/etl_tests+0xad54d84)
    #3 0x55db03f7a7fb in etl::icallback_timer_interrupt<(anonymous namespace)::ScopedGuard>::tick(unsigned int) (/home/runner/work/etl/etl/test/etl_tests+0xadd57fb)
    #4 0x55db03f74e41 in (anonymous namespace)::Suitetest_callback_timer_interrupt::Testcallback_timer_interrupt_log_timer_calls::RunImpl() const (/home/runner/work/etl/etl/test/etl_tests+0xadcfe41)
    #5 0x55db0b51dcc2 in void UnitTest::ExecuteTest<UnitTest::Test>(UnitTest::Test&, UnitTest::TestDetails const&, bool) (/home/runner/work/etl/etl/test/etl_tests+0x12378cc2)
    #6 0x55db0b51d8e3 in UnitTest::Test::Run() (/home/runner/work/etl/etl/test/etl_tests+0x123788e3)
    #7 0x55db0b52113e in UnitTest::TestRunner::RunTest(UnitTest::TestResults*, UnitTest::Test*, int) const (/home/runner/work/etl/etl/test/etl_tests+0x1237c13e)
    #8 0x55db0b521bbb in int UnitTest::TestRunner::RunTestsIf<UnitTest::True>(UnitTest::TestList const&, char const*, UnitTest::True const&, int) const (/home/runner/work/etl/etl/test/etl_tests+0x1237cbbb)
    #9 0x55db0b51ff17 in UnitTest::RunAllTests() (/home/runner/work/etl/etl/test/etl_tests+0x1237af17)
    #10 0x55db034d36d2 in main (/home/runner/work/etl/etl/test/etl_tests+0xa32e6d2)
    #11 0x7f1eafcf1c86 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21c86)
    #12 0x55db034d35e9 in _start (/home/runner/work/etl/etl/test/etl_tests+0xa32e5e9)

Address 0x7ffe36665b90 is located in stack of thread T0 at offset 928 in frame
    #0 0x55db03f744a5 in (anonymous namespace)::Suitetest_callback_timer_interrupt::Testcallback_timer_interrupt_log_timer_calls::RunImpl() const (/home/runner/work/etl/etl/test/etl_tests+0xadcf4a5)

Why it matters

Brief analysis of issues in repository suggested, that some tools already warned at least about undefined behavior elements in test code: array index issue but were explicitly ignored. Even though this particular linked issue isn't a big deal by itself. But it can have negative effects on final code quality:

1. New versions of compilers have optimization strategies based on assumption, that program isn't ill-formed and doesn't have undefined behavior code. Under that assumption, the optimizer can optimize away some checks inside tests, so they will never have a chance to report when some regression bug happens.
2. Ignoring a whole category of ub bugs in the assumption that it only contains "silly" stuff from "too pedantic" check inside of test code - can hide some real bugs in code.
3. stl/boost and other well established libraries on market all can pass its tests without ubsan/asan errors. Some organizations have policies to have this checks on and passing. So some of potential users couldn't use this library.
4. Any memory related bugs can prohibit usage of fuzzing techniques because they usually use sanitizers too.
5. I've started poking around with these flags after I encountered, that tests doesn't pass/or hang under my machine using gcc10.3 and gcc 11.2 and clang 13.0.1. And they have different behavior under different compilers. So my guess, that some issues found by asan/ubsan - are real problems(in tests themselves or in library code).

ping @jwellbelove

Hi,

I am using WSL and clang to compile a binary for Arduino. I am including <etl/bitset.h> but when I try to compile I am getting the following error:

/home/part22/avr-llvm/llvm-project/build/bin/clang++ --target=avr -DARDUINO=10813 -DARDUINO_ARCH_AVR -DARDUINO_AVR_UNO -DF_CPU=16000000L -I/home/part22/projects/arduino-clang/source/include -isystem /home/part22/projects/arduino-clang/source/third-party/etl/include -mmcu=atmega328p -nostdlib -Os -DNDEBUG -fno-lto -fdata-sections -fno-exceptions -ffunction-sections -fno-threadsafe-statics -std=c++17 -MD -MT CMakeFiles/blinky.dir/blink.cpp.obj -MF CMakeFiles/blinky.dir/blink.cpp.obj.d -o CMakeFiles/blinky.dir/blink.cpp.obj -c /home/part22/projects/arduino-clang/source/blink.cpp
In file included from /home/part22/projects/arduino-clang/source/blink.cpp:1:
In file included from /home/part22/projects/arduino-clang/source/third-party/etl/include/etl/bitset.h:43:
/home/part22/projects/arduino-clang/source/third-party/etl/include/etl/integral_limits.h:123:39: error: in-class initializer for static data member is not a constant expression
    static const unsigned short max = USHRT_MAX;
                                      ^~~~~~~~~
/home/part22/avr-llvm/llvm-project/build/lib/clang/12.0.0/include/limits.h:55:33: note: expanded from macro 'USHRT_MAX'
#define USHRT_MAX (__SHRT_MAX__ *2  +1)
                  ~~~~~~~~~~~~~~^~~~~~~

I am not sure what I did wrong here. If anyone has had the same issue, I would be glad to know how I can solve this. I am happy to provide more details if needed.

Cheers!

Hello, There are some armcc5 compilation issues with version 18.19.2 when c++11 profile is enabled.

1. https://github.com/ETLCPP/etl/blob/65fa8c51e4b47c4d36ab982cb31cbc65af5e27b2/include/etl/type_traits.h#L754 Previously there was a fix for armcc5:

   #if ETL_CPP11_SUPPORTED && !defined(ETL_COMPILER_ARM5)
   

   now it is gone.

2. basic_string.h fails to compile due flags.h with following errors:

    "statement may not appear in a constexpr function" value ? data |= (pattern & MASK) : data &= (~pattern & MASK)
   

   Probably it is due limited (buggy) constexpr support for armcc5.

3. There is a warning for function.h in line: https://github.com/ETLCPP/etl/blob/65fa8c51e4b47c4d36ab982cb31cbc65af5e27b2/include/etl/function.h#L185 because virtual keyword is missing.

Some errors don't have additional data (think of is_odd(int num) kind of function).

Add a specialization for void error type with default ctor creating an error

result<void, E> default ctor creates an error result instead of value.

This commit https://github.com/ETLCPP/etl/commit/245fbdeea9a0aa64c3128c4378883e932044a2ad changes this

[133/288] /usr/bin/x86_64-pc-linux-gnu-g++ -DETL_DEBUG -I/var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/../include -isystem /var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/UnitTest++/..  -march=native -O2 -pipe -fsanitize=address,undefined -Wall -Wextra -Werror -std=gnu++17 -MD -MT test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o -MF test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o.d -o test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o -c /var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/test_intrusive_list.cpp
FAILED: test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DETL_DEBUG -I/var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/../include -isystem /var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/UnitTest++/..  -march=native -O2 -pipe -fsanitize=address,undefined -Wall -Wextra -Werror -std=gnu++17 -MD -MT test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o -MF test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o.d -o test/CMakeFiles/etl_tests.dir/test_intrusive_list.cpp.o -c /var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/test_intrusive_list.cpp
In file included from /var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/test_intrusive_list.cpp:33:
/var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/../include/etl/intrusive_list.h: In function ‘void UnitTest::ExecuteTest(T&, const UnitTest::TestDetails&, bool) [with T = {anonymous}::Suitetest_intrusive_list::SetupFixturetest_sort_compareHelper]’:
/var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/../include/etl/intrusive_list.h:617:68: error: array subscript -1 is outside array bounds of ‘{anonymous}::DataNDC1 [1]’ {aka ‘etl::intrusive_list<{anonymous}::ItemNDCNode, etl::bidirectional_link<1> > [1]’} [-Werror=array-bounds]
  617 |       return iterator(static_cast<value_type&>(this->terminal_link));
      |                                                                    ^
/var/tmp/portage/dev-embedded/etlcpp-20.35.8/work/etl-20.35.8/test/test_intrusive_list.cpp:819:16: note: while referencing ‘data1’
  819 |       DataNDC1 data1(unsorted_data.begin(), unsorted_data.end());
      |                ^~~~~

While packaging this for Gentoo, I enabled the test suite. Unfortunately the tests do not compile with the above error. Can someone with more insight into the test suite take a look at this? Compiler is gcc (Gentoo 11.3.1_p20221209 p3) 11.3.1 20221209.

Please note that this error repeats several times for the file, I copied just the first occurrence.

Current behaviour: state_chart does not support const-qualified actions and guards. Minimal example:

#include "etl/state_chart.h"
using namespace etl;

struct SM : public state_chart<SM> {
    SM() : state_chart<SM>(*this, transitionTable.begin(), transitionTable.end(), stateTable.begin(), stateTable.end(), 0) {};

    bool always() { return true; };
    // instead, this does not compile:
    // bool always() const { return true; };

    void action() { };
    // instead, this does not compile:
    // void action() const { };

    static const array<SM::state, 1> stateTable;
    static const array<SM::transition, 1> transitionTable;
};

constexpr array<SM::state, 1> SM::stateTable = { SM::state(0, &SM::action, nullptr) };
constexpr array<SM::transition, 1> SM::transitionTable = { SM::transition(0, 0, 0, &SM::action, &SM::always) };

Hi, We would like to compile our code with "-Wsign-conversion" but enabling and using etl::string<> this emits a lot of warnings like `C:/projects/integrator/3rdParty/etl/include/etl/basic_string.h:1064:44: warning: conversion to 'etl::string_base::size_type' {aka 'unsigned int'} from 'std::iterator_traits<char*>::difference_type' {aka 'int'} may change the sign of the result [-Wsign-conversion]

1064 | const size_type start = etl::distance(begin(), position); | ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~`

Is there a workaround for this or is this a bug in ETL? BR